Dan Kenigsberg has posted comments on this change.

Change subject: Support unicode args in betterPopen
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 7: Support unicode args in betterPopen
I suppose it depends on your locale. My former result is with en_US.utf8.

 from betterPopen import BetterPopen
 from subprocess import Popen
 EXT_ECHO = '/bin/echo'
 
 data = u'\u05e9\u05dc\u05d5\u05dd'
 print 'BetterPopen'
 print BetterPopen([EXT_ECHO, "-n", data]).wait()
 print 'Popen'
 print Popen([EXT_ECHO, "-n", data]).wait()

--
To view, visit http://gerrit.ovirt.org/4414
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I194e75bfca30bcbc6d7fb0f2a24b30eb6162cddb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiaw...@linux.vnet.ibm.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to