Ayal Baron has posted comments on this change.

Change subject: Support unicode args in betterPopen
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 105:     for (item = arr; *item != NULL; item++) {
what happens if arr is NULL?

--
To view, visit http://gerrit.ovirt.org/4414
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I194e75bfca30bcbc6d7fb0f2a24b30eb6162cddb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiaw...@linux.vnet.ibm.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to