Saggi Mizrahi has posted comments on this change. Change subject: Support unicode args in betterPopen ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/betterPopen/createprocess.c Line 145: Py_FileSystemDefaultEncoding, Danken: The reason I use FileSystemDefaultEncoding is that the original python code for execve in python2.7 uses it and you wanted it to have the same semantics. ececve doesn't really have an encoding so there isn't really anything you can do. The interface is a null terminated string of characters. The assumption is that the local is a pretty good indication of how other non unicode programs will react to the arguments but it is in no way correct. As a rule you should not pass unicode objects to the function but rather encode the unicode objects to the encoding you know the receiving program expects. You wanted the me to reproduce the original behavior and I did even though I don't agree with it personally. -- To view, visit http://gerrit.ovirt.org/4414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I194e75bfca30bcbc6d7fb0f2a24b30eb6162cddb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Wenchao Xia <xiaw...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
