Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: tests: Add functional tests
......................................................................
Patch Set 1: (4 inline comments)
I think that in general it looks good, relative minor comments inline.
....................................................
File tests/functional/restTests.py
Line 44: print e.read()
Can the print be replaced by logging or something else?
Line 50: def assertHTTPError(self, code, fn, *args):
I'm not sure if the fn and args is that clear. How about just fn and lambdas in
the actual tests?
Line 74: self.assertHTTPError(404, request, "/api/doesnotexist")
This would become:
self.assertHTTPError(404, lambda: request("/api/doesnotexist"))
Line 80: self.assertHTTPError(405, request, "/api", 'json', 'data')
And this:
self.assertHTTPError(405, lambda: request("/api", 'json', 'data'))
--
To view, visit http://gerrit.ovirt.org/4452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id33dfabd7c67379351256aad8e09ad0a36e46246
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Wenchao Xia <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
