Royce Lv has posted comments on this change. Change subject: tests: Add functional tests ......................................................................
Patch Set 2: (1 inline comment) Good to me with some little suggestion .................................................... File tests/functional/restTests.py Line 43: except urllib2.HTTPError, e: I guess if the vdsm rest server is not started right, we may get this error: URLError: <urlopen error [Errno 111] Connection refused> rather than HTTPError we may also need to handle this -- To view, visit http://gerrit.ovirt.org/4452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id33dfabd7c67379351256aad8e09ad0a36e46246 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Wenchao Xia <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
