Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster cli support in supervdsm.
......................................................................
Patch Set 16: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/gluster/cli.py
Line 492: rc, out, err = _execGluster(_GLUSTER_PEER_CMD + ["detach",
hostName])
I find it nicer to have
cmd = _GLUSTER_PEER_CMD + ["detach", hostName]
if force:
cmd += ['force']
--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
