Saggi Mizrahi has posted comments on this change. Change subject: Added gluster cli support in supervdsm. ......................................................................
Patch Set 12: I would prefer that you didn't submit this (1 inline comment) Why do we need to run all the commands through superVdsm? Couldn't we have a group that allows a user to manipulate gluster volumes, preferably being able to assign creds to a volume to allow users to own gluster volumes? .................................................... File vdsm/gluster/cli.py Line 44: def wrapper(*args, **kwargs): please use functools.wraps http://docs.python.org/library/functools.html#functools.wraps -- To view, visit http://gerrit.ovirt.org/2797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
