Federico Simoncelli has posted comments on this change. Change subject: Added gluster cli support in supervdsm. ......................................................................
Patch Set 18: I would prefer that you didn't submit this (2 inline comments) Feel free to override the -1 if in hurry. .................................................... File vdsm/gluster/cli.py Line 27: from hostname import getHostNameFqdn Instead of using an external command can you use "socket.gethostname()"? .................................................... File vdsm/gluster/hostname.py Line 26: _EXT_HOSTNAME = _hostNameCommandPath.cmd This is not how utils.CommandPath should be used. The idea is to use lazy evaluation to fail only when we are asked to use a command and such command is not present (eg: getHostNameFqdn). In this case it's not a problem because /bin/hostname can be found on all platforms and so we might want to assume that it never fails, but I don't like such assumption. -- To view, visit http://gerrit.ovirt.org/2797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
