Dan Kenigsberg has posted comments on this change.
Change subject: BZ#821867: Do not append comments to config values
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/vdsmd.init.in
Line 273: sed -i --copy -e "/by vdsm/,+1{d}" "$1"
why have you stopped using the variable $BY_VDSM here?
we still need to worry about upgrade path - we should first call a legacy
function that removes exiting, in-line comments.
for the new style of comments, please consider to have a
## beginning of configuration section by vdsm
key=val
key=val
## end of configuration section by vdsm
I think it is a little bit more readable. Please have Federico review this
patch, maybe it is best to put it with his http://gerrit.ovirt.org/#change,4210
on the same branch. This change is more urgent, anyway, since it solves an
oVirt-of-F17 blocker bug.
--
To view, visit http://gerrit.ovirt.org/4716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01840754844fbcd4d3f44bd16e0627015a59af83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
