Dan Kenigsberg has posted comments on this change.
Change subject: BZ#821867: Do not append comments to config values
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/vdsmd.init.in
Line 330: for arg in "$@"
I find this confusing now. how about listing the 4 relevant configuration
files? (sorry for not noticing this earlier)
Line 332: echo "${start_conf_section} ${by_vdsm_vers}" >> $arg
unquoted "$arg".
Line 377: echo ${end_conf_section} ${by_vdsm_vers} >> $arg
you know my thing about unquoted bash variables....
--
To view, visit http://gerrit.ovirt.org/4716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01840754844fbcd4d3f44bd16e0627015a59af83
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
