Dan Kenigsberg has posted comments on this change.
Change subject: BZ#821867: Do not append comments to config values
......................................................................
Patch Set 2: No score
(1 inline comment)
....................................................
File vdsm/vdsmd.init.in
Line 274: sed -i --copy -e "/${by_vdsm_vers}/,/${by_vdsm_vers}/d" \
right. when we change by_vdsm_vers, this function would not work.
better look for the section strings
## beginning of configuration section
## end of configuration section
(define them as variables)
--
To view, visit http://gerrit.ovirt.org/4716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01840754844fbcd4d3f44bd16e0627015a59af83
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
