Dan Kenigsberg has posted comments on this change. Change subject: CpuPinning for vdsClient ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm_cli/vdsClient.py Line 158: cpuPinning = [] I'd expect a dictionary, this is surprising. Line 163: if param == 'devices': bad indentation. please run make check-local before submitting code - pyflakes should have caught this. -- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
