Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning for vdsClient
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
minor comments
....................................................
Commit Message
Line 11: cpuPinning="[{vcpu:0,cpuset:0#4}]"
I think the comment is not up-to-date.
better mention this in the run-time help text (look for 'o devices' for
example)
....................................................
File vdsm_cli/vdsClient.py
Line 158: cpuPinning = []
I find this confusing - better initialize this with an empty dict.
--
To view, visit http://gerrit.ovirt.org/4905
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
