Laszlo Hornyak has posted comments on this change.

Change subject: CpuPinning for vdsClient
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm_cli/vdsClient.py
Line 158:         cpuPinning = []
Intended to be a list of dictionaries and when creating the data through engine 
it works nicely

        cpuPinning = [{'cpuset': '2', 'vcpu': '0'}, {'cpuset': '1', 'vcpu': 
'1'}]

However, when using the command line, the client creates the wrong data 
structure:

cpuPinning = [[{'vcpu': '0', 'cpuset': '4'}, '']]

Looks like a list of list of dictionaries, plus an empty string :(

Line 163:                    if param == 'devices':
Done

--
To view, visit http://gerrit.ovirt.org/4905
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to