Dan Kenigsberg has posted comments on this change. Change subject: BZ#784931 - Restore SD.validate() semantics. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) commit message is very hard to follow. .................................................... Commit Message Line 7: BZ#784931 - Restore SD.validate() semantics. when was the semantics broken? Line 9: Domain validate checks the domain without any aging mechanism. I spent some 20 minutes trying to understand what you wrote here. How about dom.validate() should check the domain without the aging mechanism of dom.selftest(). The latter method should be kept intact since it is used by domainMonitor.py. -- To view, visit http://gerrit.ovirt.org/4955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I423777deafc4e1d9186054ec33f2744712065512 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
