Federico Simoncelli has posted comments on this change. Change subject: BZ#784931 - Restore SD.validate() semantics. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/blockSD.py Line 752: lvm.chkVG(self.sdUUID) This is just a shorter aging mechanism. Is there any problem if the VG becomes invalid between this check and the action that you are going to execute? -- To view, visit http://gerrit.ovirt.org/4955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I423777deafc4e1d9186054ec33f2744712065512 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
