Zhou Zheng Sheng has posted comments on this change. Change subject: some system call and signal will interrupt poll, making event loop stops and fails to react events and keepalive message from libvirt. adding handling EINTR to poll to make it more robust ......................................................................
Patch Set 3: (1 inline comment) .................................................... Commit Message Line 10: adding handling EINTR to poll to make it more robust I think the commit title is a bit long. Maybe you could explain the details in the first paragraph. I suggest: adding handling EINTR to poll to make it more robust some system call and signal will interrupt poll, making event loop stops and fails to react events and keepalive message from libvirt. adding EINTR handling can fix the problem. -- To view, visit http://gerrit.ovirt.org/5113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie367e193cbf4b76d352d57f3d4ef55fdf45f2fd2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
