Dan Kenigsberg has posted comments on this change. Change subject: adding handling EINTR to poll to make it more robust ......................................................................
Patch Set 6: (2 inline comments) .................................................... File vdsm/libvirtev.py Line 221: # Deduct 20ms, since schedular timeslice I'm referring only to the spelling error that you have re-introduced. Line 229: if e.errno != errno.EINTR: I cannot preach about this so soon after my f/u with http://gerrit.ovirt.org/6269 .. just test you code.. and post it for another review on libvir-list. -- To view, visit http://gerrit.ovirt.org/5113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie367e193cbf4b76d352d57f3d4ef55fdf45f2fd2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel P. Berrange <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
