Dan Kenigsberg has posted comments on this change. Change subject: adding handling EINTR to poll to make it more robust ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) thanks for posting to http://www.redhat.com/archives/libvir-list/2012-June/msg00692.html let us wait for the review there. .................................................... File vdsm/libvirtev.py Line 232: I suppose that other exceptions (say, while calling read(2)) may cause this assignment to be missed. How about putting it in a "finally" clause, with its "try" just after the self.runningPoll = True assignment? -- To view, visit http://gerrit.ovirt.org/5113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie367e193cbf4b76d352d57f3d4ef55fdf45f2fd2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel P. Berrange <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
