Ayal Baron has posted comments on this change.
Change subject: BZ#784931 - Fixing race condition in deactivateSD().
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File vdsm/storage/mount.py
Line 46: def _runcmd(cmd, timeout):
this change has no business here and is wrong anyway since the correct change
is to get rid of this function altogether.
Line 149: m = getMountFromTarget(target)
again, just:
return getMountFromTarget(target)
Line 154: else:
this is redundant
....................................................
File vdsm/storage/sp.py
Line 1050: else: #if dom.isBackup():
s/if.*/Deactivate mounted masterDirs even if domain is unreachable (i.e. cannot
rely on dom object)/
This part should not be under either one of the else clauses
Line 1066: dom.releaseHostId(self.id)
assuming you shift the above left, you need to:
if dom:
dom.releaseHostId(self.id)
--
To view, visit http://gerrit.ovirt.org/5677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If06f9cc8da81996590c366de9ad9ea2786a5d3ea
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
