Eduardo has posted comments on this change. Change subject: BZ#784931 - Fixing race condition in deactivateSD(). ......................................................................
Patch Set 3: (2 inline comments) .................................................... File vdsm/storage/sp.py Line 1050: else: #if dom.isBackup(): masterMigrate umounted the current MSD or failed with a log. In case of success this block will raise loudly and if it failed we have no reasons to assume that will succeed here. Line 1066: dom.releaseHostId(self.id) No shift no need for. -- To view, visit http://gerrit.ovirt.org/5677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If06f9cc8da81996590c366de9ad9ea2786a5d3ea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
