Michael Burns has posted comments on this change.

Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port
......................................................................


Patch Set 2:

In response to Itamar's comments:

I think this is a 3.1 blocker.  If a user installs engine 3.1 today and chooses 
to configure the firewall with engine-setup (which I expect many will do), the 
8443 port does *NOT* work.  The default firewall config blocks that port.  

As for backward compatibility, I think we can silently try a fallback port if 
the specified one fails.  

If user specifies 443 and that fails, try 8443.
If user specifies 8443 and that fails, try 443.
If user specifies 80 and that fails, try 8080.
If user specifies 8080 and that fails, try 80.
If user tries anything else, no fallback

If the fallback port fails, report a failure to connect.
If fallback passes, report Port XXX failed, using YYY instead.

--
To view, visit http://gerrit.ovirt.org/5367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb36d1ca0614741d24b512572f101f848b24e6d3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to