Michael Burns has posted comments on this change. Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port ......................................................................
Patch Set 3: (2 inline comments) code wise, this looks good, mostly. see in line comments. .................................................... File vdsm/netinfo.py Line 46: def isHostReachable(host, port=None, ssl=True, timeout=15): 15 is a long standard timeout, assuming this is in seconds... .................................................... File vdsm_reg/engine.py.in Line 198: sslPort = False what about the condition where user specifies 442 which is non-standard ssl? -- To view, visit http://gerrit.ovirt.org/5367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb36d1ca0614741d24b512572f101f848b24e6d3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
