Michael Burns has posted comments on this change.
Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port
......................................................................
Patch Set 2: (4 inline comments)
Comments on the patch, which does most of what i said in my previous comment...
....................................................
File vdsm_reg/engine.py.in
Line 191: self.ncs.screen.setColor("ACTBUTTON", "blue", "white")
maybe here, we should do something where we set the compat port
if rhevm_server_port(value) == 443:
VDC_HOST_PORT_COMPATIBLE = 8443
elif rhevm_server_port(value) == 8443:
VDC_HOST_PORT_COMPATIBLE = 443
elif rhevm_server_port(value) == 80:
VDC_HOST_PORT_COMPATIBLE = 8080
elif rhevm_server_port(value) == 8080:
VDC_HOST_PORT_COMPATIBLE = 80
else:
VDC_HOST_PORT_COMPATIBLE = None
Note: change var name to drop _3_0 -- it's just compatible port now, not just
3.0 compatible
Line 198: deployUtil.nodeCleanup()
You can check for valid port here
if can't connect to engine:port
if compat_port is not None:
msgbox: can't connect to port, trying COMPAT_PORT
set field in UI
if can't connect to engine:COMPAT_PORT:
cannot connect to engine, return
else:
cannot connect to engine, return
After this, just always use rhevm_server_port.value()
Line 202: self.processFingerPrint()
need to check return code here and return if processFingerPrint returns False
Line 204: #If the default port fail, try compatible port
for oVirt 3.0
This else becomes unnecessary if we have the check first for valid port
--
To view, visit http://gerrit.ovirt.org/5367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb36d1ca0614741d24b512572f101f848b24e6d3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
