Greg Padgett has posted comments on this change. Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf ......................................................................
Patch Set 3: This is certainly a more involved set of changes, but it follows Ayal's suggestion about how to prioritize the settings (engine first, then vdsm.conf, then defaults). If the engine passes some--but not all--options, the defaults will "fill in the blanks" just like the existing code does. The code tries to grab the values for retrans, timeo, and vers from the vdsm.conf setting (if used) and store the values in the class. If any are missing, the respective class properties will be 'None'. Thanks in advance for any feedback. -- To view, visit http://gerrit.ovirt.org/5368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
