Eduardo has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File vdsm/storage/iscsi.py
Line 354: log.warning("Performing SCSI scan, this will take up to 30
seconds")
log.debug?
Line 356: for host in glob.glob(SCAN_PATTERN):
s/host/hba
Line 361: log.warning("%s seconds is an illegal value for configuration
option: \
Split the string in sucesive strings, '\' is unnecesary. Remove the 2nd one.
Line 366: for i in xrange(30 - min_timeout):
Units issue: (int) - [sec] is wrong.
Line 375: log.warning("still waiting for: %s", ps)
Add the remaining hba's (host's) identifiers to the warning.
--
To view, visit http://gerrit.ovirt.org/6796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7665ebaed716f75af4d03ec1b6a9ff9ff5d84853
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
