Igor Lvovsky has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(2 inline comments)
it's fine, only minor comments
....................................................
File vdsm/storage/iscsi.py
Line 367: "respectively.", min_timeout, max_timeout)
Line 368: log.debug("Performing SCSI scan, this will take up to %s seconds",
Line 369: max_timeout)
Line 370: time.sleep(min_timeout)
Line 371: cycles = int((max_timeout - min_timeout) / sleep_time)
I am not sure that preparation with sleep_time=1 is a good idea
Line 372: for i in xrange(cycles):
Line 373: for p in ps[:]:
Line 374: if p[1].wait(0):
Line 375: ps.remove(p)
Line 377: break
Line 378: else:
Line 379: time.sleep(sleep_time)
Line 380: else:
Line 381: log.warning("Still waiting for hbas: %s", tuple(p[0] for p in
ps))
hba -> controller
Line 382:
Line 383: def devIsiSCSI(dev):
Line 384: hostdir = os.path.realpath(os.path.join("/sys/block", dev,
"device/../../.."))
Line 385: host = os.path.basename(hostdir)
--
To view, visit http://gerrit.ovirt.org/6796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7665ebaed716f75af4d03ec1b6a9ff9ff5d84853
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
