Ayal Baron has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File vdsm/storage/iscsi.py
Line 350: pass
Line 351:
Line 352: @misc.samplingmethod
Line 353: def forceIScsiScan():
Line 354: ps = []
s/ps/processes/
Line 355: min_timeout = config.getint('irs', 'scsi_rescan_minimal_timeout')
Line 356: max_timeout = config.getint('irs', 'scsi_rescan_maximal_timeout')
Line 357: sleep_time = 1
Line 358: for hba in glob.glob(SCAN_PATTERN):
Line 351:
Line 352: @misc.samplingmethod
Line 353: def forceIScsiScan():
Line 354: ps = []
Line 355: min_timeout = config.getint('irs', 'scsi_rescan_minimal_timeout')
convention is camel case, not underscores
Line 356: max_timeout = config.getint('irs', 'scsi_rescan_maximal_timeout')
Line 357: sleep_time = 1
Line 358: for hba in glob.glob(SCAN_PATTERN):
Line 359: cmd = ['echo', '- - -', '>', hba]
Line 360: ps.append((hba, misc.execCmd(cmd, sudo=True, sync=False)))
Line 361: if (min_timeout > max_timeout or min_timeout < 0):
Line 362: min_timeout = 2
Line 363: max_timeout = 30
Line 364: log.warning("One of the following configuration arguments has
illegal ",
s/has illegal/has an illegal/
Line 365: "value: scsi_rescan_minimal_timeout or ",
Line 366: "scsi_rescan_maximal_timeout. Set to %s and %s
seconds ",
Line 367: "respectively.", min_timeout, max_timeout)
Line 368: log.debug("Performing SCSI scan, this will take up to %s seconds",
Line 377: break
Line 378: else:
Line 379: time.sleep(sleep_time)
Line 380: else:
Line 381: log.warning("Still waiting for hbas: %s", tuple(p[0] for p in
ps))
still waiting for scsi scan of hbas: %s...
Line 382:
Line 383: def devIsiSCSI(dev):
Line 384: hostdir = os.path.realpath(os.path.join("/sys/block", dev,
"device/../../.."))
Line 385: host = os.path.basename(hostdir)
--
To view, visit http://gerrit.ovirt.org/6796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7665ebaed716f75af4d03ec1b6a9ff9ff5d84853
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
