Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add permutation feature to testing framework
......................................................................
Patch Set 7: I would prefer that you didn't submit this
I get what you're trying to achieve, but I think it's too complex. How about
using kwargs?
class SumTests(TestCaseBase):
@permutations(strategy=('recursive', 'builtin', 'loop'))
def test(self, strategy):
self.assertEquals(mysum((1, 2, 3), strategy), 6)
This will limit the more exotic options, but I'd argue that this is better
because it's easier to spot what's going on.
--
To view, visit http://gerrit.ovirt.org/6244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26871027182a151fd63c381879e72255f6161695
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
