Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Add permutation feature to testing framework ......................................................................
Patch Set 7: What you're trying to achieve looks similar to http://melp.nl/2011/02/phpunit-style-dataprovider-in-python-unit-test/. I don't argue that we should use *that* implementation, but I think it can be achieved with a single decorator per method. Secondary I think the arguments you provide in the unit tests are fairly complex and hard to follow. -- To view, visit http://gerrit.ovirt.org/6244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26871027182a151fd63c381879e72255f6161695 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
