Francesco Romani has posted comments on this change. Change subject: virt: bind console to unix domain socket ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/40704/2/vdsm/virt/vmdevices/core.py File vdsm/virt/vmdevices/core.py: Line 80: Line 81: class Console(Base): Line 82: __slots__ = ('_path',) Line 83: Line 84: CONSOLE_EXT = 'console' > depends on others, but it took me a search to figure out what this really m I can drop the extension altogether, I'm not a big fan of it. Or maybe something like '.sock' ? Line 85: Line 86: def __init__(self, *args, **kwargs): Line 87: super(Console, self).__init__(*args, **kwargs) Line 88: self._path = ( Line 84: CONSOLE_EXT = 'console' Line 85: Line 86: def __init__(self, *args, **kwargs): Line 87: super(Console, self).__init__(*args, **kwargs) Line 88: self._path = ( > os.path.join(...) Done Line 89: constants.P_OVIRT_VMCONSOLES + Line 90: self.conf['vmId'] + Line 91: '.' + Line 92: self.CONSOLE_EXT -- To view, visit https://gerrit.ovirt.org/40704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a876cd7f3b848aa9dde8123d459dc292729b303 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
