Nir Soffer has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
......................................................................
Patch Set 10:
It works, but we need to protect the secret value from jsonrpc and xmlrpc
server logs.
Thread-16::DEBUG::2015-05-12 01:10:46,536::BindingXMLRPC::1167::vds::(wrapper)
client [127.0.0.1]::call registerSecrets with ([{'usage': {'type': 'ceph',
'value': 'user 1 secret'}, 'uuid': '3a27b133-abb2-4302-8891-bd0a4032866f',
'value': 'my secret key'}, {'usage': {'type': 'ceph', 'value': 'user 2
secret'}, 'uuid': '2638b449-e076-474e-8e72-0a3130cd8f7b', 'value': 'other
secret key'}],) {}
The solution should be based on https://gerrit.ovirt.org/40707. That patch
automatically protect any parameter named "password". So possible solution
could be to rename the "value" parameter to "password".
--
To view, visit https://gerrit.ovirt.org/40712
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
