Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: Add register verb ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40966/7/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 216: cert_validation = False Line 217: Line 218: res = requests.get("{u}".format(u=url), verify=cert_validation) Line 219: if res.status_code != 200: Line 220: self.logger.debug("http response was not OK") > but this is and error, isn't it? execute_http_require failed. We must raise Thanks Dan, missed that one. Line 221: Line 222: return res.content Line 223: Line 224: def _silent_restorecon(self, path): -- To view, visit https://gerrit.ovirt.org/40966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
