Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40103/7/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 383: """ Line 384: return {'params': ret['params'], 'migrationPort': ret['migrationPort']} Line 385: Line 386: Line 387: def VM_getMigrationStatus_Ret(ret): > I thought that we agreed not to have method which only returns result. its not working other solutions suck as 'VM_getMigrationStatus': {} and 'VM_getMigrationStatus': {'ret': 'MigrationStats'} note: MigrationStats is a union in json schema Line 388: """ Line 389: Return status of the Migration, progress and downtime if available Line 390: """ Line 391: return ret -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
