Piotr Kliczewski has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40103/4/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 387: def VM_getMigrationStatus_Ret(ret): Line 388: """ Line 389: Return status of the Migration, progress and downtime if available Line 390: """ Line 391: return ret > I will ask Piotr for review You just need to define a key which is use to hold your value. This method is not needed as Francesco is suggesting. Line 392: Line 393: Line 394: def Volume_getsize_Ret(ret): Line 395: """ -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
