Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 4: Code-Review+1 (2 comments) seems OK. Please check my comment about formatting in migration.py https://gerrit.ovirt.org/#/c/40103/4/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 387: def VM_getMigrationStatus_Ret(ret): Line 388: """ Line 389: Return status of the Migration, progress and downtime if available Line 390: """ Line 391: return ret still not sure about this trivial function, but I trust your verification. Line 392: Line 393: Line 394: def Volume_getsize_Ret(ret): Line 395: """ https://gerrit.ovirt.org/#/c/40103/4/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 98: # fetch migration status from the monitor thread Line 99: self.status['progress'] = self._monitorThread.progress Line 100: Line 101: stat = self._vm._dom.jobStats(libvirt. Line 102: VIR_DOMAIN_JOB_STATS_COMPLETED) Is this intentional? Line 103: if 'downtime_net' in stat: Line 104: self.status['downtime'] = stat['downtime_net'] Line 105: Line 106: return self.status -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
