Ondřej Svoboda has posted comments on this change. Change subject: veth: replace veth.create with a context manager (from networkTests) ......................................................................
Patch Set 3: (2 comments) A (late) note to the reviewers about an import which is only being moved to the right location. https://gerrit.ovirt.org/#/c/38945/3/tests/functional/veth.py File tests/functional/veth.py: Line 21: No, this "import" is only being moved where it belongs. Line 26: import dummy This line has been moved from almost the top. -- To view, visit https://gerrit.ovirt.org/38945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58688d23ea059ced35c77fd1c4262543582ae53b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
