Petr Horáček has posted comments on this change. Change subject: veth: replace veth.create with a context manager (from networkTests) ......................................................................
Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38945/3/tests/netinfoTests.py File tests/netinfoTests.py: Line 191: with veth.pair(prefix='mehv_') as (v2a, v2b): Line 192: d2 = dummy.create(prefix='mehd_') Line 193: hiddens = set([d2, v2a, v2b]) Line 194: dummy.remove(d2) Line 195: nics = netinfo.nics() you should first get nicsfrom netinfo and then remove dummy (right?) Line 196: self.assertFalse(hiddens.intersection(nics), 'Some of hidden ' Line 197: 'devices %s is shown in nics %s' % (hiddens, Line 198: nics)) Line 199: -- To view, visit https://gerrit.ovirt.org/38945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58688d23ea059ced35c77fd1c4262543582ae53b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
