Dan Kenigsberg has submitted this change and it was merged. Change subject: veth: replace veth.create with a context manager (from networkTests) ......................................................................
veth: replace veth.create with a context manager (from networkTests) The context manager creates and later destroys a veth pair, since both actions are tied together (as can be seen in netinfoTests, where veth.pair is now employed). There is hope (an existing patch) to teach the context manager to prevent NetworkManager from taking control of network devices used in tests. Change-Id: I58688d23ea059ced35c77fd1c4262543582ae53b Signed-off-by: Ondřej Svoboda <[email protected]> Reviewed-on: https://gerrit.ovirt.org/38945 Continuous-Integration: Jenkins CI Reviewed-by: Petr Horáček <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/functional/networkTests.py M tests/functional/veth.py M tests/netinfoTests.py 3 files changed, 38 insertions(+), 47 deletions(-) Approvals: Ondřej Svoboda: Verified Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58688d23ea059ced35c77fd1c4262543582ae53b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
