Alon Bar-Lev has posted comments on this change. Change subject: vdsm-imaged: Support random io to oVirt disks ......................................................................
Patch Set 2: (7 comments) https://gerrit.ovirt.org/#/c/41824/2/vdsm-imaged/README File vdsm-imaged/README: Line 14: available via HTTP on port 54322. Line 15: Line 16: - ticket service manage session tickets authorizing image service Line 17: operations. This service is available via HTTP over Line 18: unix domain socket. > We considered two options: the engine should get the stat as you can also request a url to be downloaded directly from this daemon. Line 19: Line 20: Transfer session flow Line 21: Line 22: - Client starts an engine transfer session using oVirt REST API. Line 22: - Client starts an engine transfer session using oVirt REST API. Line 23: - Engine creates session tickets Line 24: - Engine ask Vdsm to start a transfer session with a ticket. Line 25: - Vdsm prepares an image, and add the session ticket to vdsm-imaged. Line 26: - Engine returns signed session tickets to client. > I'll update the text to reflect the difference between the tickets. you should be able to send a url to the daemon so it will download it directly. Line 27: - Client perform io operations with oVirt transfer proxy using the Line 28: signed session ticket. Line 29: - oVirt transfer proxy performs random io operations with vdsm-imaged Line 30: using the session ticket uuid. Line 33: - Vdsm deletes session ticket from vdsm-imaged. Line 34: Line 35: Session tickets are ephemeral; A client needs to request Engine to renew Line 36: the ticket from time to time, otherwise a ticket will expire and the Line 37: transfer session will be aborted. > Even when the user is redirected to the proxy, the ui will have to do multi the ticket should be validated once, and you should open http(cookie based) session directly with proxy. Line 38: Line 39: Session tickets are not persisted. In case of vdsm-imaged crash or Line 40: reboot, Engine will provide a new session ticket and possibly point https://gerrit.ovirt.org/#/c/41824/2/vdsm-imaged/imaged.py File vdsm-imaged/imaged.py: Line 45: try: Line 46: while running: Line 47: time.sleep(30) Line 48: finally: Line 49: stop() > I plan to run via systemd, so no demonizing is needed. you should not make this assumption anywhere, well at least until vdsm is aligned with your assumptions. I know you love systemd, but you limit your-self because of your assumptions. Line 50: Line 51: Line 52: def terminate(signo, frame): Line 53: global running Line 49: stop() Line 50: Line 51: Line 52: def terminate(signo, frame): Line 53: global running > This is just another way to use module global variable without the global k create a proper class. Line 54: running = False Line 55: Line 56: Line 57: def start(config): Line 91: server.serve_forever(poll_interval=config.poll_interval) Line 92: Line 93: t = threading.Thread(target=run, name=name) Line 94: t.daemon = True Line 95: t.start() > I must start 2 servers, each listening to different kind of socket, so I mu if this httpd server does not support multiple endpoints then, ok, but it sounds strange. Line 96: Line 97: Line 98: class Config(object): Line 99: Line 103: repo_dir = "/var/run/vdsm/storage" Line 104: poll_interval = 1.0 Line 105: buffer_size = 64 * 1024 Line 106: socket = "/var/run/vdsm/imaged.socket" Line 107: > What do you mean by conf.d config file structure? read xxx.d/* sort by name and merge last wins. Line 108: @property Line 109: def key_file(self): Line 110: return os.path.join(self.pki_dir, "keys", "vdsmkey.pem") Line 111: -- To view, visit https://gerrit.ovirt.org/41824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3339fa94ef8464228cd036f4fe8eea61887e337 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
