Alon Bar-Lev has posted comments on this change. Change subject: vdsm-imaged: Support random io to oVirt disks ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41824/2/vdsm-imaged/README File vdsm-imaged/README: Line 33: - Vdsm deletes session ticket from vdsm-imaged. Line 34: Line 35: Session tickets are ephemeral; A client needs to request Engine to renew Line 36: the ticket from time to time, otherwise a ticket will expire and the Line 37: transfer session will be aborted. > This is the flow as I'm planning. again... there should be two tokens each for different purpose. the transaction token is to be used by the endpoint, in your case is the imaged. the access token which is used as a mechanism to transfer authentication between webapp and proxy, no more no less. non interactive application, these that communicate directly with the vdsm/imaged should use only transaction tokens. the webadmin/userportal and the proxy should use the access tokens to enable only authorized users to pass the proxy with the approved transaction details. Line 38: Line 39: Session tickets are not persisted. In case of vdsm-imaged crash or Line 40: reboot, Engine will provide a new session ticket and possibly point -- To view, visit https://gerrit.ovirt.org/41824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3339fa94ef8464228cd036f4fe8eea61887e337 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
