Nir Soffer has posted comments on this change. Change subject: vdsm-imaged: Support random io to oVirt disks ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/41824/2/vdsm-imaged/README File vdsm-imaged/README: Line 22: - Client starts an engine transfer session using oVirt REST API. Line 23: - Engine creates session tickets Line 24: - Engine ask Vdsm to start a transfer session with a ticket. Line 25: - Vdsm prepares an image, and add the session ticket to vdsm-imaged. Line 26: - Engine returns signed session tickets to client. > you should be able to send a url to the daemon so it will download it direc Ok, this functionality is already implemented in vdsm, but I guess that it makes sense to move it out of vdsm into the new daemon. However, even if you pass a url, you still need a ticket - engine will start a download session, vdsm will prepare the image and ask the daemon to download from a url. So in this case, the client does not need any interaction with the proxy. If the url is not accessible from the host, the proxy will download from the url and send the data to the host. I still see no need for direct interaction without a ticket, except local access for debugging. Line 27: - Client perform io operations with oVirt transfer proxy using the Line 28: signed session ticket. Line 29: - oVirt transfer proxy performs random io operations with vdsm-imaged Line 30: using the session ticket uuid. Line 33: - Vdsm deletes session ticket from vdsm-imaged. Line 34: Line 35: Session tickets are ephemeral; A client needs to request Engine to renew Line 36: the ticket from time to time, otherwise a ticket will expire and the Line 37: transfer session will be aborted. > the ticket should be validated once, and you should open http(cookie based) Ok, but this text is about the communication between the proxy and the daemon on the host. We plan to use the access token created by the engine to authorize the request from the proxy. Do you think that a uuid4 will be good enough for this, or we want a longer key? Line 38: Line 39: Session tickets are not persisted. In case of vdsm-imaged crash or Line 40: reboot, Engine will provide a new session ticket and possibly point -- To view, visit https://gerrit.ovirt.org/41824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3339fa94ef8464228cd036f4fe8eea61887e337 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
