Francesco Romani has posted comments on this change. Change subject: serial console: add code to prepare the path ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/41896/5/vdsm/vmconsole.py File vdsm/vmconsole.py: Line 49: """ Line 50: Line 51: Line 52: def create_directory(path, log): Line 53: head, tail = os.path.split(os.path.normpath(path)) > what is the difference between this and dirname which somewhat more clear? Actually I don't have a good reason NOT to use dirname(). Since dirname() is declared to be equivalent to os.path.split(some_path)[0] will just switch to dirname in the next upload. Line 54: dirname = tempfile.mkdtemp(dir=head) Line 55: Line 56: os.chmod(dirname, _VIRT_VMCONSOLE_MODE) Line 57: chown(dirname, VDSM_USER, QEMU_PROCESS_GROUP) -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
