Dan Kenigsberg has posted comments on this change. Change subject: serial console: add code to prepare the path ......................................................................
Patch Set 6: Code-Review-1 (2 comments) -1 for visibility https://gerrit.ovirt.org/#/c/41896/6//COMMIT_MSG Commit Message: Line 6: Line 7: serial console: add code to prepare the path Line 8: Line 9: Add support for vmconsole path preparation. Line 10: The new supervdsm method ensures that the unix domain socket directory this seems a bit over-complex. Maybe I miss something, but task_mkdirs in vdsmd_init_common.sh.in could create this directory easily. Line 11: needed by ovirt-vmconsole integration exists and has Line 12: the following permissions, ownership and SELinux attributes: Line 13: Line 14: /var/run/ovirt-vmconsole-console/ drwxrwxr-x. vdsm qemu system_u:object_r:qemu_var_run_t:s0 https://gerrit.ovirt.org/#/c/41896/6/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 195: Line 196: ('ssl_protocol', 'sslv23', Line 197: 'SSL protocol used by encrypted connection'), Line 198: Line 199: ('vm_console_enable', 'true', why do we want to make this configurable? Any reason a user would like not to use this? Line 200: 'Enable VM serial console access using ovirt-vmconsole.'), Line 201: ]), Line 202: Line 203: # Section: [mom] -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
