Ala Hino has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 ......................................................................
Patch Set 20: (2 comments) https://gerrit.ovirt.org/#/c/41931/20//COMMIT_MSG Commit Message: Line 8: Line 9: Verify that only Replica 3 volumes are used in gluster storage domains. Line 10: We enforce replica 3 because this is the recommended deployment for virt Line 11: and gluster. Line 12: We added a configuration mainly to enable developers test gluster without > What do you mean by "mainly"? I think this is the only reason for adding th Done Line 13: the need to create replica 3 volumes. Line 14: Line 15: Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Line 16: Bug-Url: https://bugzilla.redhat.com/1123052 https://gerrit.ovirt.org/#/c/41931/20/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 302: self._gluster_options = self._get_gluster_mount_options() Line 303: comma = ',' Line 304: if self._options is "" or self._gluster_options is "": Line 305: comma = "" Line 306: return self._options + comma + self._gluster_options > This works, but we do it in a pythonic way, similar to NFSConnection: Done Line 307: Line 308: @property Line 309: def volinfo(self): Line 310: if self._volinfo is None: -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
