Nir Soffer has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 ......................................................................
Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/41931/22/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 287 Line 288 Line 289 Line 290 Line 291 Now that we have cached volume info, we don't need to cache the gluster options. Lets replace this with: @property def options(self) gluster_options = self._get_gluster_mount_options() return ",".join(p for p in (self._options, gluster_options) if p) -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
