Ala Hino has posted comments on this change.

Change subject: gluster: Allow gluster mount with additional servers
......................................................................


Patch Set 19:

(1 comment)

https://gerrit.ovirt.org/#/c/40665/19/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 299:             return ""
Line 300: 
Line 301:         volfileServer, volname = self._remotePath.split(":", 1)
Line 302:         volname = volname.strip('/')
Line 303:         volInfo = supervdsm.getProxy().glusterVolumeInfo(volname,
> Ala, check how NFSConnection is handling such fatal failures.
I don't see a suitable (gluster) exception in storage_exception.py.
I will add a suitable exception and update the engine part in separate patches.
Line 304:                                                          
volfileServer)
Line 305:         servers = [brick.split(":")[0]
Line 306:                    for brick in volInfo[volname]['bricks']]
Line 307:         servers.remove(volfileServer)


-- 
To view, visit https://gerrit.ovirt.org/40665
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Darshan N <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to