Nir Soffer has posted comments on this change. Change subject: gluster: Allow gluster mount with additional servers ......................................................................
Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/40665/22/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 286: Line 287: @property Line 288: def options(self): Line 289: self._gluster_options = self._get_gluster_mount_options() Line 290: return ",".join(p for p in (self._options, self._gluster_options) if p) Why did you remove the lazy initialization here? it is valid only in the next patch, where you cache the volume info. If you compute the value on each call, why do you need the _gluster_options variable? Please keep the original code, and change only the way you join the arguments. Line 291: Line 292: def _get_gluster_mount_options(self): Line 293: if "backup-volfile-servers" in self._options: Line 294: self.log.warn("User specified mount options will be used.") -- To view, visit https://gerrit.ovirt.org/40665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
