Dan Kenigsberg has posted comments on this change.
Change subject: fix TypeError of _eqSplit in vdsClient.py
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I would prefer to drop the whole "if". Any reason not to? Clearly, the "else"
branch is never used.
....................................................
File vdsm_cli/vdsClient.py
Line 1407: kv = arg.split('=', 1)
Line 1408: if len(kv) == 2:
Line 1409: k, v = kv
Line 1410: else:
Line 1411: k, v = kv[0], ''
it's not your fault, but why do we need this whole condition? I think it would
be better to explode over sending a key with empty-string value.
Line 1412: d[k] = v
Line 1413: return d
Line 1414:
Line 1415: def _splitDriveSpecItems(self, item):
--
To view, visit http://gerrit.ovirt.org/7200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b5573499adaa1b64f8343b445cc16df8f60f3d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
