Dan Kenigsberg has posted comments on this change. Change subject: fix TypeError of _eqSplit in vdsClient.py ......................................................................
Patch Set 2: I would prefer that you didn't submit this > IMO, for bool options, such as "xx=Ture" and "xx" should the same. The patch does not give us this semantics. it makes "xx" equivalent to "xx=''", which is not really desirable. I'd still prefer to drop handling the "xx" case, and fail such an operation. If you find it very important to have this semantics, please document it in the commit message. -- To view, visit http://gerrit.ovirt.org/7200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98b5573499adaa1b64f8343b445cc16df8f60f3d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
